Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of custom init/stop in scraper and use start/shutdown from component #2193

Merged
merged 1 commit into from
Nov 23, 2020

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

@codecov
Copy link

codecov bot commented Nov 23, 2020

Codecov Report

Merging #2193 (37e1fff) into master (14a7f03) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2193   +/-   ##
=======================================
  Coverage   91.98%   91.98%           
=======================================
  Files         268      268           
  Lines       15691    15693    +2     
=======================================
+ Hits        14433    14435    +2     
  Misses        857      857           
  Partials      401      401           
Impacted Files Coverage Δ
...eceiver/internal/scraper/cpuscraper/cpu_scraper.go 100.00% <ø> (ø)
...nternal/scraper/diskscraper/disk_scraper_others.go 100.00% <ø> (ø)
...eiver/internal/scraper/loadscraper/load_scraper.go 100.00% <ø> (ø)
...internal/scraper/networkscraper/network_scraper.go 97.89% <ø> (ø)
...rnal/scraper/processesscraper/processes_scraper.go 77.77% <ø> (ø)
...internal/scraper/processscraper/process_scraper.go 98.13% <ø> (ø)
...nternal/scraper/swapscraper/swap_scraper_others.go 100.00% <ø> (ø)
service/internal/resources.go 25.33% <ø> (ø)
...icsreceiver/internal/scraper/cpuscraper/factory.go 100.00% <100.00%> (ø)
...csreceiver/internal/scraper/diskscraper/factory.go 100.00% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14a7f03...37e1fff. Read the comment docs.

…om component

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu merged commit 7874cd5 into open-telemetry:master Nov 23, 2020
@bogdandrutu bogdandrutu deleted the scraper branch November 23, 2020 19:00
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants