Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change zipkin translator to not use consumerdata #2509

Merged
merged 1 commit into from
Feb 19, 2021

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #2509 (c6fc4f1) into main (dba4edb) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2509      +/-   ##
==========================================
- Coverage   91.76%   91.73%   -0.03%     
==========================================
  Files         265      265              
  Lines       15092    15092              
==========================================
- Hits        13849    13845       -4     
- Misses        863      866       +3     
- Partials      380      381       +1     
Impacted Files Coverage Δ
...lator/trace/zipkin/zipkinv1_thrift_to_protospan.go 79.57% <ø> (ø)
translator/trace/zipkin/zipkinv1_to_protospan.go 95.49% <100.00%> (ø)
exporter/exporterhelper/metricshelper.go 94.59% <0.00%> (-5.41%) ⬇️
exporter/otlpexporter/otlp.go 71.79% <0.00%> (-2.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dba4edb...c6fc4f1. Read the comment docs.

@bogdandrutu bogdandrutu merged commit ba720d8 into open-telemetry:main Feb 19, 2021
@bogdandrutu bogdandrutu deleted the zipkin branch February 19, 2021 16:35
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants