Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ExporterObsReport to Exporter #2658

Merged

Conversation

naseemkullah
Copy link
Member

since obsreport is the package name

fixes #2642

since obsreport is the package name

fixes open-telemetry#2642

Signed-off-by: naseemkullah <naseem@transit.app>
@naseemkullah naseemkullah requested a review from a team as a code owner March 10, 2021 14:17
@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #2658 (6dbc235) into main (06770d1) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2658   +/-   ##
=======================================
  Coverage   92.04%   92.04%           
=======================================
  Files         278      278           
  Lines       15432    15432           
=======================================
  Hits        14204    14204           
  Misses        845      845           
  Partials      383      383           
Impacted Files Coverage Δ
exporter/exporterhelper/logshelper.go 100.00% <100.00%> (ø)
exporter/exporterhelper/metricshelper.go 94.59% <100.00%> (ø)
exporter/exporterhelper/tracehelper.go 100.00% <100.00%> (ø)
exporter/prometheusexporter/prometheus.go 100.00% <100.00%> (ø)
obsreport/obsreport_exporter.go 95.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06770d1...6dbc235. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename ExporterObsReport to just Exporter since obsreport is the package name
2 participants