Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Kafka receiver to not use internal data #2697

Merged
merged 1 commit into from
Mar 16, 2021

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu requested a review from a team as a code owner March 14, 2021 20:10
@codecov
Copy link

codecov bot commented Mar 14, 2021

Codecov Report

Merging #2697 (93a01ee) into main (03904de) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2697      +/-   ##
==========================================
- Coverage   91.81%   91.81%   -0.01%     
==========================================
  Files         290      290              
  Lines       15559    15557       -2     
==========================================
- Hits        14285    14283       -2     
  Misses        876      876              
  Partials      398      398              
Impacted Files Coverage Δ
receiver/kafkareceiver/otlp_unmarshaller.go 100.00% <100.00%> (ø)
receiver/kafkareceiver/unmarshaller.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03904de...93a01ee. Read the comment docs.

Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is PR description correct? I don't see any changes that remove internal data usage. (That's a good idea to do BTW, so that we can move Kafka to contrib).

Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, I see it now.

@bogdandrutu bogdandrutu merged commit adaf38c into open-telemetry:main Mar 16, 2021
@bogdandrutu bogdandrutu deleted the kafkarecv branch March 16, 2021 18:06
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants