Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support max batch size for logs #2736

Merged

Conversation

gregoryfranklin
Copy link
Contributor

Similar to #2422, this adds support for send_batch_max_size to batch processor for logs. Meaning this parameter is now supported for traces, metrics and logs (previously only traces and metrics were supported).

@gregoryfranklin gregoryfranklin requested a review from a team March 19, 2021 15:51
@bogdandrutu bogdandrutu reopened this Mar 24, 2021
Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog entry

@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #2736 (39fc584) into main (8050a88) will decrease coverage by 0.04%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2736      +/-   ##
==========================================
- Coverage   91.83%   91.79%   -0.05%     
==========================================
  Files         289      290       +1     
  Lines       15523    15563      +40     
==========================================
+ Hits        14256    14286      +30     
- Misses        870      879       +9     
- Partials      397      398       +1     
Impacted Files Coverage Δ
processor/batchprocessor/batch_processor.go 84.49% <0.00%> (-5.59%) ⬇️
processor/batchprocessor/splitlogs.go 93.75% <93.75%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8050a88...39fc584. Read the comment docs.

@bogdandrutu bogdandrutu merged commit 49ddca9 into open-telemetry:main Mar 24, 2021
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants