Refactor ConfigValidator #2856
Merged
Refactor ConfigValidator #2856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
commented
Mar 30, 2021
Codecov Report
@@ Coverage Diff @@
## main #2856 +/- ##
==========================================
- Coverage 91.77% 91.77% -0.01%
==========================================
Files 286 286
Lines 15159 15158 -1
==========================================
- Hits 13912 13911 -1
Misses 853 853
Partials 394 394
Continue to review full report at Codecov.
|
bogdandrutu
force-pushed
the
configvalidate
branch
from
6a49224
to
63e28c8
Compare
|
The expected error on line 144 from |
bogdandrutu
force-pushed
the
configvalidate
branch
from
63e28c8
to
30b148e
Compare
tigrannajaryan
approved these changes
Mar 30, 2021
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
force-pushed
the
configvalidate
branch
from
30b148e
to
464a2a6
Compare
pjanotti
pushed a commit
to pjanotti/opentelemetry-service
that referenced
this pull request
Apr 6, 2021
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup after #2802
Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com