exporter/prometheusexporter: support Summary #2900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2900 +/- ##
=======================================
Coverage 91.67% 91.67%
=======================================
Files 311 287 -24
Lines 15308 15284 -24
=======================================
- Hits 14033 14011 -22
Misses 868 868
+ Partials 407 405 -2
Continue to review full report at Codecov.
|
odeke-em
force-pushed
the
prometheus-exporter-support-Summary-Metric
branch
from
720d235
to
5fa2c7d
Compare
odeke-em
force-pushed
the
prometheus-exporter-support-Summary-Metric
branch
2 times, most recently
from
e50e22c
to
d991f64
Compare
|
Alright, ready for action, kindly cc-ing some reviewers @alolita @Aneurysm9 @rakyll @bogdandrutu @brian-brazil. |
brian-brazil
reviewed
Apr 9, 2021
Aneurysm9
reviewed
Apr 9, 2021
Aneurysm9
approved these changes
Apr 9, 2021
bogdandrutu
reviewed
Apr 12, 2021
bogdandrutu
reviewed
Apr 12, 2021
odeke-em
force-pushed
the
prometheus-exporter-support-Summary-Metric
branch
from
c36b80c
to
1a89d7f
Compare
@bogdandrutu sorry I don't follow what you mean, all I talked about was that now we export Summary through the prometheusexporter, where does "the ignore of no sum is fixed" relate? Thanks for the review too! |
bogdandrutu
approved these changes
Apr 12, 2021
|
@odeke-em please fix lint errors |
Allows Summary metrics to be exported to Prometheus. To walk through this feature, I created an adaptation of a Brian Brazil tutorial for DropWizard, to create a Java server at https://github.com/odeke-em/bugs/tree/master/opentelemetry-collector/2661 and it uses DropWizard, and exports out JVM statistics with Prometheus where the *gc_collection_seconds are of the summary kind when scraped by visiting http://localhost:1234/metrics which produced ``` # HELP jvm_gc_collection_seconds Time spent in a given JVM garbage collector in seconds. # TYPE jvm_gc_collection_seconds summary jvm_gc_collection_seconds_count{gc="G1 Young Generation",} 4.0 jvm_gc_collection_seconds_sum{gc="G1 Young Generation",} 0.026 jvm_gc_collection_seconds_count{gc="G1 Old Generation",} 0.0 ``` and then roundtripped the collector to scrape those metrics and then export them to Prometheus VS making Prometheus directly scrape that endpoint and then comparing results. Also added an end to end test to ensure that a mock DropWizard server which produces JVM statistics can be scraped by the Prometheus receiver, which will feed metrics to an active Prometheus exporter, and then we scrape from the Prometheus exporter to ensure that the summary metrics are written out and that they make sense. DropWizard -> Prometheus Receiver -> Prometheus Exporter -> HTTP scrape + Verify Fixes open-telemetry#2661
odeke-em
force-pushed
the
prometheus-exporter-support-Summary-Metric
branch
from
1a89d7f
to
eaaf2ab
Compare
|
@bogdandrutu done, although the "lint" flagged legitimate Go code in 2 cases that don't make sense so might want to look at the false positives. Thank you for the reviews @Aneurysm9 and @bogdandrutu! |
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
* Increase timeout to 10m for golangci-lint * Add Makefile.common to workflow triggers * Use --allow-parallel-runners for signalfx-agent lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows Summary metrics to be exported to Prometheus.
To walk through this feature, I created an adaptation of a Brian Brazil
tutorial for DropWizard, to create a Java server at
https://github.com/odeke-em/bugs/tree/master/opentelemetry-collector/2661
and it uses DropWizard, and exports out JVM statistics with Prometheus where the
*gc_collection_seconds are of the summary kind when scraped by visiting
http://localhost:1234/metrics which produced
and then roundtripped the collector to scrape those metrics and then
export them to Prometheus
making Prometheus directly scrape that endpoint and then comparing
results.
Fixes #2661