exporters/prometheusremotewrite: Do not append '_total' to counter metric names #2993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2993 +/- ##
==========================================
- Coverage 92.06% 91.65% -0.42%
==========================================
Files 313 312 -1
Lines 15439 15427 -12
==========================================
- Hits 14214 14139 -75
- Misses 817 881 +64
+ Partials 408 407 -1
Continue to review full report at Codecov.
|
…tric names. This appears to have been enforcing convention but isn't actually required. Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
Aneurysm9
force-pushed
the
prom_name_label
branch
from
233114c
to
420f897
Compare
rakyll
approved these changes
Apr 23, 2021
…tor into prom_name_label
|
Kindly cc-ing @bogdandrutu. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
cc @open-telemetry/collector-approvers |
|
@anuraaga @open-telemetry/collector-approvers - please take a look and approve. There are other Prometheus issues that are dependent on this fix being merged. |
…tor into prom_name_label
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
dashpole
approved these changes
May 12, 2021
…tor into prom_name_label
…tor into prom_name_label
…n PRW exporter Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
alolita
added
the
ready-to-merge
carlosalberto
approved these changes
May 17, 2021
bogdandrutu
approved these changes
May 17, 2021
|
I think this needs a rebase to pass the required checks |
…tor into prom_name_label
dashpole
pushed a commit
to dashpole/opentelemetry-collector
that referenced
this pull request
Jun 14, 2021
…tric names (open-telemetry#2993) * exporters/prometheusremotewrite: Do not append '_total' to counter metric names. This appears to have been enforcing convention but isn't actually required. Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com> * Address PR feedback Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com> * Update CHANGELOG.md to reflect removal of _total suffix enforcement in PRW exporter Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
Co-authored-by: jeffreyc-splunk <jeffreyc-splunk@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This appears to have been enforcing convention but isn't actually required.
Description: The
prometheusremotewriteexporterno longer appends "_total" to the name of counter metrics that don't already end in "_total". This was exposed by the PRW conformance test suite and this change partially addresses open-telemetry/wg-prometheus#43.