Fix missing startTimestamp for processes scraper. #3461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Wire boot timestamp through to processes scraper (matches all other host metrics receivers). - Add a more verbose output on timestmap failure for easier diagnostics when making failing changes to these tests. - Update tests to ensure starttime is set in resulting metrics.
jmacd
approved these changes
Jun 18, 2021
jrcamp
approved these changes
Jun 18, 2021
punya
approved these changes
Jun 18, 2021
alolita
added
area:receiver
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The
processesscraper inhostmetricsreceiverdid not use boot startTime, unlike the rest of the scrapers.While I'd consider this a bug, could be considered a minor feature request. Specifically, the OTLP spec strongly recommends start timestamps for points with Aggregation Temporarily. This is not required due to compatibility with non-OTel metric format, but we should have a really good reason not to provide a valid timestamp.
I just found this yesterday, can open a bug for this PR if needed.
Here's what I did:
Testing:
Added unit tests and ran locally.