service: only initialize telemetry once to prevent errors in multiple instances #3918
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: only initialize internal telemetry once.
This change updates the init() method for
colTelemetry
(which is a singleton) to run at most once. This allows multiple collector instances to be run in the same process.Link to tracking Issue: open-telemetry/prometheus-interoperability-spec/issues/34
Testing: Manually tested and was able to create multiple collectors in the same process, while previously, it would error out with:
/cc @odeke-em