Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated pdata.TimestampFromTime. #3935

Merged

Conversation

a-feld
Copy link
Member

@a-feld a-feld commented Aug 30, 2021

Description: Removes the pdata.TimestampFromTime function in preparation for pdata release candidate.

Fixes #3925

@a-feld a-feld requested review from a team and tigrannajaryan August 30, 2021 20:33
@bogdandrutu
Copy link
Member

Thanks, we need to release first 0.34.0 then we can remove this, but will keep this PR.

Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking since we need to wait for the release

@bogdandrutu bogdandrutu changed the title Remove deprecated pdata.TimestampFromTime. Closes: #3925 Remove deprecated pdata.TimestampFromTime. Aug 30, 2021
Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v0.34.0 was released

@bogdandrutu bogdandrutu merged commit 4ecdfce into open-telemetry:main Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated funcs pdata.TimestampFromTime in v0.35.0
2 participants