Update k8s config to use opentelemetry docker image and configuration #459
Conversation
ccaraman
requested review from
bogdandrutu,
flands,
owais,
pjanotti,
rghetia,
songy23 and
tigrannajaryan
as code owners
Codecov Report
@@ Coverage Diff @@
## master #459 +/- ##
==========================================
+ Coverage 75.72% 77.28% +1.56%
==========================================
Files 120 121 +1
Lines 7345 8528 +1183
==========================================
+ Hits 5562 6591 +1029
- Misses 1520 1652 +132
- Partials 263 285 +22
Continue to review full report at Codecov.
|
examples/k8s.yaml
Outdated
| # port: 9411 | ||
| - name: jaeger-tchannel | ||
| port: 14267 | ||
| - name: jaeger_thrift_http |
There was a problem hiding this comment.
nit: for consistency let's use either - or _
There was a problem hiding this comment.
I'll use lower case for consistency - but it doesn't matter too much for this as they are just the names for the ports.
examples/k8s.yaml
Outdated
| num_workers: 8 | ||
| reconnection_delay: 2s | ||
| secure: true | ||
| zipkin: {} |
There was a problem hiding this comment.
should we list down options for other core exporters/receivers in the examples?
There was a problem hiding this comment.
The goal of this config is to give everyone a starting point for k8s - the config.yaml for each component(exporter, receiver, etc) give more detailed examples.
examples/k8s.yaml
Outdated
| reconnection_delay: 2s | ||
| secure: true | ||
| zipkin: {} | ||
| jaeger: {} |
There was a problem hiding this comment.
wasn't jaeger split into the jaeger_grpc and jaeger_thrift_http exporters?
There was a problem hiding this comment.
Good catch - didn't realise that happened in the v0.2.0 release updating that now
examples/k8s.yaml
Outdated
| - "--config=/conf/otel-agent-config.yaml" | ||
| image: omnition/opencensus-agent:0.1.6 | ||
| image: omnition/opentelemetry-collectort:v0.2.0 |
There was a problem hiding this comment.
the image name has a typo with an extra t at the end and should be:
image: omnition/opentelemetry-collector:v0.2.0
There was a problem hiding this comment.
Good catch - i'll update :)
| # - containerPort: 14267 | ||
| # - containerPort: 14268 | ||
| # - containerPort: 9411 | ||
| - containerPort: 55678 # Default Opencensus receiver port. |
There was a problem hiding this comment.
In the current ConfigMap for otel-agnet, the open census endpoint is not set
opentelemetry-collector/examples/k8s.yaml
Line 12 in be399dc
I am not sure if it means the open census receiver is open or not, while the container port 55678 is open here.
There was a problem hiding this comment.
OpenCensus receiver has a default port so once it is specified in the receiver list it will be accepting traffic on 55678.
…open-telemetry#459) * Update k8s config to use opentelemetry docker image and configuration * Address pr comments * Add queued retry to agent config * Set memory ballast cli parameter
…etry#459) * add simplified export pipeline setup for Jaeger * add With* options to configure SDK options. * add test for WithRegistration and WithSDK * rename Registeration with RegisterGlobal * rename WithRegistration to RegisterAsGlobal Co-authored-by: rahulpa <rahulpa@google.com> Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
…y#459) Bumps [boto3](https://github.com/boto/boto3) from 1.17.89 to 1.17.90. - [Release notes](https://github.com/boto/boto3/releases) - [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst) - [Commits](boto/boto3@1.17.89...1.17.90) --- updated-dependencies: - dependency-name: boto3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Resolves #366 by updating configuration to use Otel model and v0.2.0 docker image.
The docker compose instructions and configs are correct and up to date https://github.com/open-telemetry/opentelemetry-collector/tree/master/examples/demo