Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define a type for onChange func instead of func pointer #4656

Merged
merged 1 commit into from
Jan 8, 2022

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

@codecov
Copy link

codecov bot commented Jan 7, 2022

Codecov Report

Merging #4656 (01a3386) into main (aadec29) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4656      +/-   ##
==========================================
- Coverage   90.52%   90.52%   -0.01%     
==========================================
  Files         179      179              
  Lines       10641    10638       -3     
==========================================
- Hits         9633     9630       -3     
  Misses        785      785              
  Partials      223      223              
Impacted Files Coverage Δ
config/configmapprovider/env.go 100.00% <100.00%> (ø)
config/configmapprovider/file.go 100.00% <100.00%> (ø)
config/configmapprovider/properties.go 90.62% <100.00%> (ø)
service/internal/telemetrylogs/logger.go 85.71% <0.00%> (-0.96%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aadec29...01a3386. Read the comment docs.

config/configmapprovider/provider.go Outdated Show resolved Hide resolved
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just confirming this is a change to improve the usability of the interface? I didn't see an issue associated or a description for the change.

config/configmapprovider/provider.go Outdated Show resolved Hide resolved
config/configmapprovider/provider.go Outdated Show resolved Hide resolved
service/config_provider.go Outdated Show resolved Hide resolved
@bogdandrutu
Copy link
Member Author

@codeboten yes, this PR is just to offer a more intuitive API, essentially instead of relying on the name of the variable to suggest what the function does, we define a type with a good name.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu merged commit 2317957 into open-telemetry:main Jan 8, 2022
@bogdandrutu bogdandrutu deleted the watcher branch January 8, 2022 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants