-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define a type for onChange func instead of func pointer #4656
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4656 +/- ##
==========================================
- Coverage 90.52% 90.52% -0.01%
==========================================
Files 179 179
Lines 10641 10638 -3
==========================================
- Hits 9633 9630 -3
Misses 785 785
Partials 223 223
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just confirming this is a change to improve the usability of the interface? I didn't see an issue associated or a description for the change.
@codeboten yes, this PR is just to offer a more intuitive API, essentially instead of relying on the name of the variable to suggest what the function does, we define a type with a good name. |
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com