Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of LogRecord.Name field #4804

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

tigrannajaryan
Copy link
Member

The LogRecord Name field is removed from the specification and is going to be removed from the OTLP.

@tigrannajaryan tigrannajaryan requested review from a team and Aneurysm9 February 3, 2022 21:43
@codecov
Copy link

codecov bot commented Feb 3, 2022

Codecov Report

Merging #4804 (37b7094) into main (7cdf8c7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4804   +/-   ##
=======================================
  Coverage   90.70%   90.70%           
=======================================
  Files         179      179           
  Lines       10566    10566           
=======================================
  Hits         9584     9584           
  Misses        763      763           
  Partials      219      219           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cdf8c7...37b7094. Read the comment docs.

@tigrannajaryan tigrannajaryan added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Feb 3, 2022
model/otlp/json_test.go Outdated Show resolved Hide resolved
The LogRecord Name field [is removed](open-telemetry/opentelemetry-specification#2271) from the specification and is [going to be removed](open-telemetry/opentelemetry-proto#357) from the OTLP.
@bogdandrutu bogdandrutu merged commit 18fb011 into open-telemetry:main Feb 8, 2022
@jpkrohling jpkrohling added this to the v0.45.0 milestone Feb 17, 2022
@tigrannajaryan tigrannajaryan deleted the deprecate-name branch March 3, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants