Fix wrong name suggestion made by bogdandrutu #6033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In open-telemetry#5929, the suggestion to have the combined name as "MarshalerSizer" was wrong. Even the comment open-telemetry#5929 (comment) was wrong since the link is `WriteSeeker`. Signed-off-by: Bogdan <bogdandrutu@gmail.com>
bogdandrutu
force-pushed
the
fixbogdan
branch
from
a668ef4
to
91f2632
Compare
Codecov ReportBase: 92.07% // Head: 92.07% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #6033 +/- ##
=======================================
Coverage 92.07% 92.07%
=======================================
Files 213 213
Lines 13322 13322
=======================================
Hits 12266 12266
Misses 838 838
Partials 218 218
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
dmitryax
approved these changes
Sep 6, 2022
This was referenced Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #5929, the suggestion to have the combined name as "MarshalerSizer" was wrong.
Even the comment #5929 (comment) was wrong since the link is
WriteSeeker.Signed-off-by: Bogdan bogdandrutu@gmail.com