Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle partial success responses in the OTLP exporter #6971

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Handle partial success responses in the OTLP exporter #6971

merged 1 commit into from
Jun 8, 2023

Conversation

evan-bradley
Copy link
Contributor

Description:

Handle partial success messages returned from OTLP gRPC backends.

Link to tracking Issue:

Fixes #6686

Testing:

Unit tests. I haven't been able to test this against any live backends, any recommendations would be welcome.

@evan-bradley evan-bradley requested a review from a team as a code owner January 19, 2023 00:27
@codecov
Copy link

codecov bot commented Jan 19, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (a8a01ef) 91.25% compared to head (e27da35) 91.27%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6971      +/-   ##
==========================================
+ Coverage   91.25%   91.27%   +0.01%     
==========================================
  Files         296      296              
  Lines       14477    14498      +21     
==========================================
+ Hits        13211    13233      +22     
+ Misses       1002     1001       -1     
  Partials      264      264
Impacted Files Coverage Δ
exporter/otlpexporter/otlp.go 95.68% <100.00%> (+2.00%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@evan-bradley evan-bradley force-pushed the otlp-partial-success branch 2 times, most recently from 4a47822 to 0906ead Compare January 19, 2023 17:29
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2023

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Feb 3, 2023
@github-actions github-actions bot removed the Stale label Feb 8, 2023
@evan-bradley evan-bradley requested review from bogdandrutu and removed request for jpkrohling February 9, 2023 19:50
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Feb 24, 2023
@github-actions github-actions bot removed the Stale label Mar 2, 2023
@evan-bradley
Copy link
Contributor Author

@bogdandrutu @jpkrohling could one of you please take a look?

I will look into the decreased test coverage again today. Last time I checked, it wanted me to test what was essentially an impossible condition, but I will see if I can cover it.

@jpkrohling
Copy link
Member

@bogdandrutu seems to have had concerns with the log statement. Perhaps @dmitryax or @codeboten could take a look as well, in case @bogdandrutu is not available?

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Mar 18, 2023
@dmitryax dmitryax removed the Stale label Mar 22, 2023
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Apr 21, 2023
@codeboten codeboten removed the Stale label Apr 21, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2023

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label May 6, 2023
@dmitryax dmitryax removed the Stale label May 7, 2023
@dmitryax
Copy link
Member

dmitryax commented May 7, 2023

@evan-bradley do you think we need to merge this now or wait until we have a long-term plan as discussed in #7439 (comment)?

@evan-bradley
Copy link
Contributor Author

@dmitryax I think we can merge this as-is, I don't expect any functional changes to how partial success responses are handled even after we change the errors.

@evan-bradley
Copy link
Contributor Author

@dmitryax Could you give this a look? I think it is ready to go, and would like to be able to use this.

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label May 31, 2023
@dmitryax dmitryax removed the Stale label May 31, 2023
@dmitryax
Copy link
Member

@dmitryax I think we can merge this as-is, I don't expect any functional changes to how partial success responses are handled even after we change the errors.

Ok, maybe it'll change the messaging only

@evan-bradley
Copy link
Contributor Author

Ok, maybe it'll change the messaging only

I expect that to be the only thing that changes, since we will still be returning some form of permanent error.

dmitryax
dmitryax approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a temporary solution until we have structured permanent errors

@dmitryax dmitryax merged commit 0fe29a0 into open-telemetry:main Jun 8, 2023
@github-actions github-actions bot added this to the next release milestone Jun 8, 2023
@jmacd jmacd mentioned this pull request Jun 28, 2023
Closed
@evan-bradley evan-bradley mentioned this pull request Jun 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten left review comments

@joaopgrassi joaopgrassi joaopgrassi left review comments

@dmitryax dmitryax dmitryax approved these changes

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.80.0
Development

Successfully merging this pull request may close these issues.

Handle partial success responses from OTLP export services
6 participants
@evan-bradley @jpkrohling @dmitryax @codeboten @bogdandrutu @joaopgrassi