Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pdata] Deprecate pcommon.Map.Sort() #6989

Merged
merged 1 commit into from
Jan 21, 2023

Conversation

dmitryax
Copy link
Member

This method will be removed as it leaks the underlying implementation.
One of the following alternatives should be used instead:

  • Map.AsRaw() if you need to compare two maps in tests.
  • github.com/open-telemetry/opentelemetry-collector-contrib/pkg/pdatatest module if you use Sort()
    to prepare other pdata objects for comparison.
  • github.com/open-telemetry/opentelemetry-collector-contrib/pkg/pdatautil module if you use Sort()
    to create Map identifiers.

Updates #6688

@dmitryax dmitryax requested review from a team and Aneurysm9 January 21, 2023 19:43
@codecov
Copy link

codecov bot commented Jan 21, 2023

Codecov Report

Base: 90.67% // Head: 90.67% // No change to project coverage 👍

Coverage data is based on head (ad0647b) compared to base (d97f1eb).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6989   +/-   ##
=======================================
  Coverage   90.67%   90.67%           
=======================================
  Files         241      241           
  Lines       14525    14525           
=======================================
  Hits        13171    13171           
  Misses       1087     1087           
  Partials      267      267           
Impacted Files Coverage Δ
pdata/pcommon/common.go 94.44% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bogdandrutu bogdandrutu merged commit 51c9139 into open-telemetry:main Jan 21, 2023
codeboten pushed a commit to codeboten/opentelemetry-collector that referenced this pull request Jan 23, 2023
@dmitryax dmitryax deleted the deprecate-map-sort branch January 23, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants