-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] [pdata] Add test coverage for slices Sort method #7115
Conversation
Codecov ReportBase: 90.59% // Head: 90.82% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #7115 +/- ##
==========================================
+ Coverage 90.59% 90.82% +0.22%
==========================================
Files 293 293
Lines 14254 14254
==========================================
+ Hits 12914 12946 +32
+ Misses 1072 1040 -32
Partials 268 268
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
df9317e
to
a811629
Compare
return uintptr(unsafe.Pointer(a.orig)) < uintptr(unsafe.Pointer(b.orig)) | ||
}) | ||
for i := 1; i < es.Len(); i++ { | ||
assert.True(t, uintptr(unsafe.Pointer(es.At(i-1).orig)) < uintptr(unsafe.Pointer(es.At(i).orig))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assert.Less?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Surprisingly assert.Less doesn't support uintptr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying to fix that :) stretchr/testify#1339
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a TODO to change this if the PR gets merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
a811629
to
4b7cbc6
Compare
No description provided.