[WIP] Customising service metrics with additional views, reader and server #7696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptodev
changed the title
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
ptodev
force-pushed
the
customize-service-telemetry
branch
from
952ac3d
to
42e0fbb
Compare
ptodev
force-pushed
the
customize-service-telemetry
branch
from
42e0fbb
to
c379a56
Compare
|
Hello, if a maintainer has a chance to review and opine whether this approach has potential, it would be much appreciated please :) |
|
@open-telemetry/collector-maintainers any thoughts? |
This was referenced Jun 16, 2023
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
ping @open-telemetry/collector-maintainers |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two changes in the PR:
service.Newfunction./metricserver.This could be useful to users of the Collector who want to leverage the functionality of the service module, but who need to extend it with their own metric server, views and readers.
The change in this PR was discussed recently on the CNCF slack channel for the collector, on this thread.
Alternative solutions to this problem have already been discussed in #4970. So far they have mostly been turned down because overriding telemetry settings could contradict other settings in the service config.
There is one potential issue with this change. Unfortunately, the
useExternalMetricsServercould indeed contradict the config. If the config specifies a telemetry metrics address anduseExternalMetricsServer = true, then Collector wouldn't start a Prometheus server. However, if you think passing views and metric readers is ok, I could think of a way to minimise the contradictions whichuseExternalMetricsServerwould introduce.On Slack it was also mentioned that there is work underway to include metric readers and views in the config, and that this change could potentially contradict them (or at least provide another way to configure the same thing):
I would be happy to add a changelog entry, tests and documentation if needed. There is currently no GitHub issue created for this particular approach, but I would be happy to create one if needed as well.