-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[featuregate] Validate arguments to Register
#8766
[featuregate] Validate arguments to Register
#8766
Conversation
Register
Codecov ReportAll modified and coverable lines are covered by tests ✅
... and 3 files with indirect coverage changes 📢 Thoughts on this report? Let us know! |
Signed-off-by: Alex Boten <aboten@lightstep.com>
Can you take one (hopefully) final look @bogdandrutu ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to have the same setup in core like https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/.gitattributes to not expand all the sum files.
See #8810 |
Description:
,
to avoid ambiguity in the CLI, but I am being intentionally more restrictive herenet/url
stdlib packageTo/FromVersion
options using hashicorp's libraries and also that the implicit version range, when defined, is not empty.This does not change the public API types, it only adds validation.
Relates to #8220