Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] [exporterhelper] Move queue creation parameters to structs #9197

Merged
merged 1 commit into from
Jan 2, 2024
Merged

[chore] [exporterhelper] Move queue creation parameters to structs #9197

merged 1 commit into from
Jan 2, 2024

Conversation

dmitryax
Copy link
Member

Address #8853 (comment)

@dmitryax dmitryax requested a review from a team as a code owner December 31, 2023 20:32
@dmitryax dmitryax mentioned this pull request Dec 31, 2023
Merged
@codecov Codecov
Copy link

codecov bot commented Dec 31, 2023 •
edited
Loading

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (e7e73ab) 90.34% compared to head (8103360) 90.34%.

Files Patch % Lines
...porter/exporterhelper/internal/persistent_queue.go 67.74% 10 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #9197   +/-   ##
=======================================
  Coverage   90.34%   90.34%           
=======================================
  Files         340      340           
  Lines       18324    18331    +7     
=======================================
+ Hits        16555    16562    +7     
  Misses       1429     1429           
  Partials      340      340

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmitryax dmitryax merged commit 7f7b826 into open-telemetry:main Jan 2, 2024
31 of 32 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 2, 2024
@dmitryax dmitryax deleted the move-out-queue-settings branch January 2, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9 Aneurysm9 is a code owner automatically assigned from open-telemetry/collector-approvers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.92.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dmitryax @bogdandrutu