[otelcol] Add unit test for implicit config use case #9302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9302 +/- ##
==========================================
+ Coverage 90.33% 90.36% +0.02%
==========================================
Files 340 340
Lines 17968 17968
==========================================
+ Hits 16232 16237 +5
+ Misses 1412 1407 -5
Partials 324 324 ☔ View full report in Codecov by Sentry. |
bogdandrutu
approved these changes
Jan 17, 2024
otelcol/command_test.go
Outdated
| @@ -26,6 +27,26 @@ func TestNewCommandNoConfigURI(t *testing.T) { | |||
| require.Error(t, cmd.Execute()) | |||
| } | |||
|
|
|||
| // This test emulates usage of Collector in Jaeger all-in-one, which | |||
| // allows running the binary with no explicit configuration. | |||
| func TestNewCommandImplicitConfig(t *testing.T) { | |||
There was a problem hiding this comment.
Can we call this "ProgrammaticallyPassConfig"?
Signed-off-by: Yuri Shkuro <github@ysh.us>
bogdandrutu
approved these changes
Jan 22, 2024
TylerHelmuth
pushed a commit
to TylerHelmuth/opentelemetry-collector
that referenced
this pull request
Jan 23, 2024
…9302) **Description:** * Add unit test that illustrates running the command without an external config * This models how Jaeger all-in-one uses collector because all-in-one can be run without arguments, for maximum user friendliness --------- Signed-off-by: Yuri Shkuro <github@ysh.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: