Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/nopexporter] Add the nopexporter #9448

Merged
merged 1 commit into from
Mar 12, 2024
Merged

[exporter/nopexporter] Add the nopexporter #9448

merged 1 commit into from
Mar 12, 2024

Conversation

evan-bradley
Copy link
Contributor

Description:

Add the nopexporter. This can be helpful if a user wants to start the Collector with a dummy pipeline to only enable extensions. It could also be used to test Collector pipeline throughput.

Link to tracking Issue:

Resolves #7316

Testing:

Added lifecycle tests; the receiver doesn't do anything.

Documentation:

Added a readme for the component.

cc @djaglowski @tigrannajaryan

@evan-bradley evan-bradley requested a review from a team as a code owner January 31, 2024 19:54
@codecov Codecov
Copy link

codecov bot commented Jan 31, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 90.93%. Comparing base (2413346) to head (99b2cf7).

Files Patch % Lines
.../nopexporter/internal/metadata/generated_status.go 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9448      +/-   ##
==========================================
- Coverage   90.95%   90.93%   -0.02%     
==========================================
  Files         350      352       +2     
  Lines       18576    18591      +15     
==========================================
+ Hits        16895    16906      +11     
- Misses       1354     1358       +4     
  Partials      327      327

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@evan-bradley evan-bradley force-pushed the nopexporter branch 7 times, most recently from 64edd08 to c3ea079 Compare February 6, 2024 17:24
andrzej-stencel
andrzej-stencel approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@andrzej-stencel andrzej-stencel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🎉

hughesjj
hughesjj approved these changes Feb 7, 2024
View reviewed changes
Copy link

@hughesjj hughesjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and makes sense to me. My only bikeshed would be nop vs noop but both are acceptable spellings.

@evan-bradley
Copy link
Contributor Author

My only bikeshed would be nop vs noop but both are acceptable spellings.

I would prefer noop myself, but it seems like nop is more conventional in Go and within the Collector. If others feel the same way, I'm open to changing the name.

@tigrannajaryan
Copy link
Member

My only bikeshed would be nop vs noop but both are acceptable spellings.

I would prefer noop myself, but it seems like nop is more conventional in Go and within the Collector. If others feel the same way, I'm open to changing the name.

+1 to nop. One less character.

dmitryax
dmitryax approved these changes Feb 29, 2024
View reviewed changes
exporter/nopexporter/go.mod Outdated Show resolved Hide resolved
@evan-bradley evan-bradley force-pushed the nopexporter branch 2 times, most recently from ba1d75e to 9bf2fa1 Compare February 29, 2024 17:28
@evan-bradley evan-bradley force-pushed the nopexporter branch 3 times, most recently from b57dca4 to b975513 Compare March 7, 2024 03:47
@dmitryax
Copy link
Member

dmitryax commented Mar 7, 2024

@evan-bradley please run make gogenerate to make CI green

@evan-bradley evan-bradley force-pushed the nopexporter branch 2 times, most recently from 4e21d16 to efe045b Compare March 8, 2024 20:36
@evan-bradley
Copy link
Contributor Author

@dmitryax Took a bit of tweaking. Should be good to go now.

@dmitryax dmitryax merged commit 454f050 into open-telemetry:main Mar 12, 2024
46 of 47 checks passed
@github-actions github-actions bot added this to the next release milestone Mar 12, 2024
tomasmota pushed a commit to tomasmota/opentelemetry-collector that referenced this pull request Mar 14, 2024
@evan-bradley @tomasmota
[exporter/nopexporter] Add the nopexporter (open-telemetry#9448)
1fe43cf 
**Description:**

Add the nopexporter. This can be helpful if a user wants to start the
Collector with a dummy pipeline to only enable extensions. It could also
be used to test Collector pipeline throughput.

**Link to tracking Issue:**

Resolves
open-telemetry#7316

**Testing:**

Added lifecycle tests; the receiver doesn't do anything.

**Documentation:**

Added a readme for the component.

cc @djaglowski @tigrannajaryan
@evan-bradley evan-bradley mentioned this pull request Jun 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hughesjj hughesjj hughesjj approved these changes

@djaglowski djaglowski djaglowski approved these changes

@dmitryax dmitryax dmitryax approved these changes

@andrzej-stencel andrzej-stencel andrzej-stencel approved these changes

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu bogdandrutu is a code owner automatically assigned from open-telemetry/collector-approvers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.97.0
Development

Successfully merging this pull request may close these issues.

nop receiver/exporter as a released components
6 participants
@evan-bradley @tigrannajaryan @dmitryax @hughesjj @djaglowski @andrzej-stencel