-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter/nopexporter] Add the nopexporter #9448
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9448 +/- ##
==========================================
- Coverage 90.95% 90.93% -0.02%
==========================================
Files 350 352 +2
Lines 18576 18591 +15
==========================================
+ Hits 16895 16906 +11
- Misses 1354 1358 +4
Partials 327 327 ☔ View full report in Codecov by Sentry. |
64edd08
to
c3ea079
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and makes sense to me. My only bikeshed would be nop
vs noop
but both are acceptable spellings.
c3ea079
to
03aa984
Compare
I would prefer |
03aa984
to
90b7f89
Compare
+1 to |
90b7f89
to
c3b7386
Compare
ba1d75e
to
9bf2fa1
Compare
b57dca4
to
b975513
Compare
@evan-bradley please run |
4e21d16
to
efe045b
Compare
efe045b
to
99b2cf7
Compare
@dmitryax Took a bit of tweaking. Should be good to go now. |
**Description:** Add the nopexporter. This can be helpful if a user wants to start the Collector with a dummy pipeline to only enable extensions. It could also be used to test Collector pipeline throughput. **Link to tracking Issue:** Resolves open-telemetry#7316 **Testing:** Added lifecycle tests; the receiver doesn't do anything. **Documentation:** Added a readme for the component. cc @djaglowski @tigrannajaryan
Description:
Add the nopexporter. This can be helpful if a user wants to start the Collector with a dummy pipeline to only enable extensions. It could also be used to test Collector pipeline throughput.
Link to tracking Issue:
Resolves #7316
Testing:
Added lifecycle tests; the receiver doesn't do anything.
Documentation:
Added a readme for the component.
cc @djaglowski @tigrannajaryan