Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[confmap] Remove deprecated confmap.WithErrorUnused #9503

Merged
merged 3 commits into from
Feb 8, 2024

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Feb 6, 2024

Description:
Remove deprecated confmap.WithErrorUnused

Link to tracking Issue:
Fixes #9484

@atoulme atoulme requested review from a team and Aneurysm9 February 6, 2024 21:59
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (87dd2af) 90.36% compared to head (865c621) 90.37%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9503      +/-   ##
==========================================
+ Coverage   90.36%   90.37%   +0.01%     
==========================================
  Files         346      346              
  Lines       18200    18194       -6     
==========================================
- Hits        16446    16443       -3     
+ Misses       1422     1418       -4     
- Partials      332      333       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atoulme atoulme force-pushed the remove_withErrorUnused branch 2 times, most recently from ff6e252 to 13e0a0c Compare February 6, 2024 22:06
@atoulme atoulme force-pushed the remove_withErrorUnused branch from 13e0a0c to 201a155 Compare February 6, 2024 22:12
@mx-psi mx-psi added needed-for-1.0 release:required-for-ga Must be resolved before GA release and removed needed-for-1.0 labels Feb 7, 2024
@bogdandrutu
Copy link
Member

@atoulme need to fix contrib

@atoulme
Copy link
Contributor Author

atoulme commented Feb 7, 2024

Yes, waiting for open-telemetry/opentelemetry-collector-contrib#31104 and I'll rerun.

@mx-psi mx-psi merged commit cf51a35 into open-telemetry:main Feb 8, 2024
47 checks passed
@github-actions github-actions bot added this to the next release milestone Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:required-for-ga Must be resolved before GA release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[confmap] Remove deprecated WithErrorUnused
3 participants