Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Move logging out of meter provider initialization #9729

Merged
merged 3 commits into from
Apr 16, 2024

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Mar 8, 2024

Description:

Moves logging messages about the meter provider outside of the meter provider initialization.

While working on #4970 (comment), I realized there is an implicit dependency in the initialization order of the different telemetry components.

I tried making this work and make the factory have a single CreateTelemetrySettings, but this results in an awkward API, so I am trying the alternative here: don't log during the meter provider initialization, but do so outside of it.

Link to tracking Issue: Relates to #4970

@mx-psi mx-psi requested a review from a team as a code owner March 8, 2024 14:07
@mx-psi mx-psi requested a review from codeboten March 8, 2024 14:07
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 62.06897% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 91.31%. Comparing base (2ff9795) to head (da4a1d7).

Files Patch % Lines
service/service.go 42.10% 9 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9729      +/-   ##
==========================================
- Coverage   91.32%   91.31%   -0.02%     
==========================================
  Files         357      357              
  Lines       19179    19191      +12     
==========================================
+ Hits        17516    17525       +9     
- Misses       1335     1337       +2     
- Partials      328      329       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added Stale and removed Stale labels Mar 26, 2024
@codeboten codeboten merged commit 370c6d1 into open-telemetry:main Apr 16, 2024
48 of 49 checks passed
@github-actions github-actions bot added this to the next release milestone Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants