-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated public methods to accept context.context in confighttp
#9870
Updated public methods to accept context.context in confighttp
#9870
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase
And please update the version in all the comments |
2345750
to
4b5d68e
Compare
Hope this is okay now @dmitryax |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9870 +/- ##
==========================================
- Coverage 91.32% 91.30% -0.03%
==========================================
Files 357 357
Lines 19179 19185 +6
==========================================
Hits 17516 17516
- Misses 1335 1341 +6
Partials 328 328 ☔ View full report in Codecov by Sentry. |
…text-in-`confighttp`
…text-in-`confighttp`
…ept-context.Context-in-`confighttp`
…text-in-`confighttp`
…text-in-`confighttp`
Hello @codeboten @dmitryax @TylerHelmuth |
@AkhigbeEromo, it looks like the CI checks are failing. Would you be able to address them? |
…text-in-`confighttp`
Yes i will work on it now @jpkrohling |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing my comments 👍🏻
@AkhigbeEromo I believe the CI is failing again because of the ` in your branch name or the length of it. |
Oh yes @TylerHelmuth Cause I once I change the name, the PR will automatically close. Will rename it now |
Added context.Context to the following functions:
Link: #9807