Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated public methods to accept context.context in confighttp #9870

Conversation

AkhigbeEromo
Copy link
Contributor

Added context.Context to the following functions:

  • ToClient
  • ToServer
  • ToListener

Link: #9807

@AkhigbeEromo AkhigbeEromo requested a review from a team as a code owner March 29, 2024 01:11
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase

config/confighttp/confighttp.go Outdated Show resolved Hide resolved
@dmitryax
Copy link
Member

And please update the version in all the comments

@AkhigbeEromo AkhigbeEromo force-pushed the Updated-public-methods-to-accept-context.Context-in-`confighttp` branch from 2345750 to 4b5d68e Compare March 29, 2024 22:13
@AkhigbeEromo AkhigbeEromo reopened this Mar 29, 2024
@AkhigbeEromo
Copy link
Contributor Author

Hope this is okay now @dmitryax

Copy link

codecov bot commented Mar 30, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 91.30%. Comparing base (2ff9795) to head (c22df92).

Files Patch % Lines
config/confighttp/confighttp.go 62.50% 3 Missing ⚠️
receiver/otlpreceiver/otlp.go 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9870      +/-   ##
==========================================
- Coverage   91.32%   91.30%   -0.03%     
==========================================
  Files         357      357              
  Lines       19179    19185       +6     
==========================================
  Hits        17516    17516              
- Misses       1335     1341       +6     
  Partials      328      328              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AkhigbeEromo
Copy link
Contributor Author

Hello @codeboten @dmitryax @TylerHelmuth
I have made changes
Is there anything else you would like me to add

@jpkrohling
Copy link
Member

@AkhigbeEromo, it looks like the CI checks are failing. Would you be able to address them?

@AkhigbeEromo
Copy link
Contributor Author

Yes i will work on it now @jpkrohling

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my comments 👍🏻

@TylerHelmuth
Copy link
Member

@AkhigbeEromo I believe the CI is failing again because of the ` in your branch name or the length of it.

@AkhigbeEromo
Copy link
Contributor Author

Oh yes @TylerHelmuth
I wanted to make sure I have successfully made all the changes I need to

Cause I once I change the name, the PR will automatically close.

Will rename it now

@AkhigbeEromo AkhigbeEromo deleted the Updated-public-methods-to-accept-context.Context-in-`confighttp` branch April 4, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants