Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated public methods in configauth #9880

Conversation

AkhigbeEromo
Copy link
Contributor

Added context.Context to the following functions:

@AkhigbeEromo AkhigbeEromo requested review from a team and jpkrohling April 2, 2024 22:00
@AkhigbeEromo
Copy link
Contributor Author

Hello @TylerHelmuth, i just worked on it

thanks for the advice

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.

Project coverage is 92.45%. Comparing base (c7c3401) to head (cca7136).
Report is 29 commits behind head on main.

Current head cca7136 differs from pull request most recent head 0f77bfa

Please upload reports for the commit 0f77bfa to get more accurate results.

Files Patch % Lines
config/configauth/configauth.go 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9880      +/-   ##
==========================================
- Coverage   92.59%   92.45%   -0.14%     
==========================================
  Files         387      387              
  Lines       18198    18256      +58     
==========================================
+ Hits        16850    16879      +29     
- Misses       1007     1031      +24     
- Partials      341      346       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AkhigbeEromo
Copy link
Contributor Author

I am having an error from codecov bot saying some lines of my code are missing coverage.

i checked what the issue was and it was because I did not write tests for the functions that are getting deprecated
Is there anything I need to do? @TylerHelmuth

@TylerHelmuth
Copy link
Member

@AkhigbeEromo dont worry about that check for this PR

Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

config/configauth/configauth.go Outdated Show resolved Hide resolved
config/configauth/configauth.go Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented May 8, 2024

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added Stale and removed Stale labels May 8, 2024
@TylerHelmuth
Copy link
Member

@AkhigbeEromo please handle merge conflicts

@AkhigbeEromo
Copy link
Contributor Author

Okay @TylerHelmuth
Will work on that

@AkhigbeEromo
Copy link
Contributor Author

hope its good now ? @TylerHelmuth

config/configauth/configauth.go Outdated Show resolved Hide resolved
config/configauth/configauth.go Show resolved Hide resolved
config/configauth/configauth.go Outdated Show resolved Hide resolved
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label May 25, 2024
config/configgrpc/configgrpc.go Outdated Show resolved Hide resolved
config/confighttp/confighttp.go Outdated Show resolved Hide resolved
@AkhigbeEromo
Copy link
Contributor Author

Hello @jpkrohling, hope it is okay now?

@github-actions github-actions bot removed the Stale label May 29, 2024
@TylerHelmuth TylerHelmuth added the ready-to-merge Code review completed; ready to merge by maintainers label May 29, 2024
config/configauth/configauth.go Outdated Show resolved Hide resolved
config/configauth/configauth.go Outdated Show resolved Hide resolved
@codeboten codeboten merged commit c0e8a0b into open-telemetry:main Jun 4, 2024
46 checks passed
@github-actions github-actions bot added this to the next release milestone Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants