-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated public methods in configauth #9880
Updated public methods in configauth #9880
Conversation
Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
Hello @TylerHelmuth, i just worked on it thanks for the advice |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9880 +/- ##
==========================================
- Coverage 92.59% 92.45% -0.14%
==========================================
Files 387 387
Lines 18198 18256 +58
==========================================
+ Hits 16850 16879 +29
- Misses 1007 1031 +24
- Partials 341 346 +5 ☔ View full report in Codecov by Sentry. |
I am having an error from codecov bot saying some lines of my code are missing coverage. i checked what the issue was and it was because I did not write tests for the functions that are getting deprecated |
@AkhigbeEromo dont worry about that check for this PR |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
@AkhigbeEromo please handle merge conflicts |
Okay @TylerHelmuth |
hope its good now ? @TylerHelmuth |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Hello @jpkrohling, hope it is okay now? |
Added context.Context to the following functions:
Link to the issue: [configauth] Update public methods to accept context.Context #9808