Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated public methods in confighttp #9895

Conversation

AkhigbeEromo
Copy link
Contributor

Added context.Context to the following functions:

ToClient
ToServer
ToListener
Link: #9807

@AkhigbeEromo AkhigbeEromo requested a review from a team as a code owner April 4, 2024 20:29
@AkhigbeEromo
Copy link
Contributor Author

Is there anything else you would like me to add @jpkrohling @dmitryax @TylerHelmuth

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 91.31%. Comparing base (b8690b6) to head (c1f270e).

Files Patch % Lines
config/confighttp/confighttp.go 62.50% 3 Missing ⚠️
receiver/otlpreceiver/otlp.go 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9895      +/-   ##
==========================================
- Coverage   91.34%   91.31%   -0.03%     
==========================================
  Files         357      357              
  Lines       19196    19202       +6     
==========================================
  Hits        17534    17534              
- Misses       1334     1340       +6     
  Partials      328      328              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AkhigbeEromo

@codeboten codeboten merged commit 79ccf55 into open-telemetry:main Apr 5, 2024
48 of 49 checks passed
@github-actions github-actions bot added this to the next release milestone Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants