[cmd/mdatagen] Move component config test from cmd/builder #9940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
generate-config-check
branch
2 times, most recently
from
f51221a to
2797e5f
Compare
|
cc @swiatekm-sumo |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9940 +/- ##
==========================================
- Coverage 91.95% 91.78% -0.17%
==========================================
Files 357 357
Lines 16501 16499 -2
==========================================
- Hits 15173 15144 -29
- Misses 1000 1032 +32
+ Partials 328 323 -5 ☔ View full report in Codecov by Sentry. |
dmitryax
force-pushed
the
generate-config-check
branch
4 times, most recently
from
59be8af to
fc2385f
Compare
The generated tests are skipped in contrib because they cause the CI timeouts. We moved the lifecycle tests to the tests generated by mdatagen, but the config/factory smoke tests are still part of the files generated by cmd/builder. Recently, loadbalancing exporter got an invalid camelCase config field because of this coverage gap. This change moves the config/factory tests from cmd/builder to cmd/mdatagen. So they are always generated for every component even if they are not used in any collector bundle.
dmitryax
force-pushed
the
generate-config-check
branch
from
fc2385f to
e479f1d
Compare
dmitryax
added a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Apr 12, 2024
These files are not generated by the builder anymore and replaced by the tests generated by mdatagen for each component independently, see open-telemetry/opentelemetry-collector#9940
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests generated by cmd/builder are skipped in contrib because they cause the CI timeouts. We moved the lifecycle tests to the tests generated by mdatagen, but the config/factory smoke tests are still part of the files generated by cmd/builder.
Recently, the loadbalancing exporter got an invalid camelCase config field because of this coverage gap.
This change moves the config/factory tests from cmd/builder to cmd/mdatagen. So, they are always generated for every component, even if not used in any collector bundle.