Configure exporter default aggregation and temporality preference #107
Conversation
| } | ||
| } | ||
| }, | ||
| "AggregationTemporalityPreference": { |
There was a problem hiding this comment.
The spec says that aggregation temporality should be configurable as a function of instrument kind, but most users will want to use these shorthand options.
This is much simpler / more compact than writing the preference for each instrument kind. In the future, we can add a separate property to give full control over temporality by instrument kind if needed.
| } | ||
| } | ||
| }, | ||
| "Aggregation": { |
There was a problem hiding this comment.
Lifting this aggregation type def up from the view stream definition. Its now reused both for view stream config and in exporter default aggregation config.
| @@ -32,7 +32,9 @@ meter_provider: | |||
| <<: *otlp-exporter | |||
| endpoint: http://localhost:4318/v1/metrics | |||
| temporality_preference: delta | |||
| default_histogram_aggregation: base2_exponential_bucket_histogram | |||
| default_aggregation_by_instrument_kind: | |||
There was a problem hiding this comment.
what if I want to
- have an aggregation preference for all kinds?
- have settings that apply for all exporters?
I see that there is a yaml anchor - but I'm not sure this should be the only option to share values
There was a problem hiding this comment.
Using anchors makes using the config easier. No need to merge properties from some global exporter config with per-exporter config. And simplifies the schema.
There was a problem hiding this comment.
it's a lesser known and complicated feature
|
Closing this. Can revisit if there's more demand for configuration outside of the defaults. |
With open-telemetry/opentelemetry-specification#4142 merged, the spec now has explicit configuration options for each metric exporter's temporality preference and default temporality.
This PR extends the metric exporters with new properties:
temporality_preferenceanddefault_aggregation_by_instrument_kindpropertiesdefault_aggregation_by_instrument_kindpropertydefault_histogram_aggregationproperty migrates to new more expressivedefault_aggregation_by_instrument_kindpropertyThis supersedes #99.