Skip to content

Commit

Permalink
[BUILD] Fix missing dependency on protoc compiler (#3159)
Browse files Browse the repository at this point in the history
  • Loading branch information
marcalff authored Nov 22, 2024
1 parent f1b5fbd commit 09c0616
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion cmake/opentelemetry-proto.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,9 @@ add_custom_command(
${LOGS_PROTO} ${METRICS_PROTO} ${TRACE_SERVICE_PROTO} ${LOGS_SERVICE_PROTO}
${METRICS_SERVICE_PROTO} ${PROFILES_PROTO}
${PROFILES_SERVICE_PROTO}
COMMENT "[Run]: ${PROTOBUF_RUN_PROTOC_COMMAND}")
COMMENT "[Run]: ${PROTOBUF_RUN_PROTOC_COMMAND}"
DEPENDS ${PROTOBUF_PROTOC_EXECUTABLE}
)

include_directories("${GENERATED_PROTOBUF_PATH}")

Expand Down

1 comment on commit 09c0616

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'OpenTelemetry-cpp api Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 09c0616 Previous: f1b5fbd Ratio
BM_ProcYieldSpinLockThrashing/1/process_time/real_time 0.2264507801459511 ms/iter 0.11266737568135164 ms/iter 2.01

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.