Skip to content

Commit

Permalink
review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
lalitb committed Sep 1, 2020
1 parent 4958615 commit 0f4592b
Show file tree
Hide file tree
Showing 2 changed files with 30 additions and 3 deletions.
19 changes: 17 additions & 2 deletions api/include/opentelemetry/http/http_client.h
Original file line number Diff line number Diff line change
@@ -1,4 +1,16 @@
// Copyright (c) Microsoft. All rights reserved
// Copyright The OpenTelemetry Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

#pragma once

Expand Down Expand Up @@ -40,9 +52,12 @@ class HttpHeaders
virtual void add(nostd::string_view const& name, nostd::string_view const& value) = 0;

// Gets a string value given a name
// Returns:
// If there are multiple headers with same name, it returns any one of the value (implementation defined)
// Empty string if there is no header with speicfied name..
virtual nostd::string_view const& get(nostd::string_view const& name) const = 0;

// Tests whether the headers contains the specified name.
// Tests whether the headers contain the specified name.
virtual bool has(nostd::string_view const& name) const = 0;
};

Expand Down
14 changes: 13 additions & 1 deletion sdk/include/opentelemetry/sdk/http/http_client.h
Original file line number Diff line number Diff line change
@@ -1,4 +1,16 @@
// Copyright (c) Microsoft. All rights reserved.
// Copyright The OpenTelemetry Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

#pragma once
#include "opentelemetry/http/http_client.h"
Expand Down

0 comments on commit 0f4592b

Please sign in to comment.