Jaeger exporter: attributes of unsupported types (#1115)

open-telemetry · Dec 4, 2021 · 2351125 · 2351125
1 parent baeee42
commit 2351125
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/exporters/jaeger/src/thrift_sender.cc b/exporters/jaeger/src/thrift_sender.cc
@@ -3,6 +3,7 @@
 
 #include "thrift_sender.h"
 #include <opentelemetry/exporters/jaeger/recordable.h>
+#include "opentelemetry/sdk/common/global_log_handler.h"
 #include "udp_transport.h"
 
 OPENTELEMETRY_BEGIN_NAMESPACE
@@ -16,7 +17,7 @@ using namespace jaegertracing;
 ThriftSender::ThriftSender(std::unique_ptr<Transport> &&transport)
     : transport_(std::move(transport)),
       protocol_factory_(new apache::thrift::protocol::TCompactProtocolFactory()),
-      thrift_buffer_(new apache::thrift::transport::TMemoryBuffer())
+      thrift_buffer_(new apache::thrift::transport::TMemoryBuffer(transport_->MaxPacketSize()))
 {}
 
 int ThriftSender::Append(std::unique_ptr<JaegerRecordable> &&span) noexcept
@@ -43,7 +44,7 @@ int ThriftSender::Append(std::unique_ptr<JaegerRecordable> &&span) noexcept
   const uint32_t span_size = CalcSizeOfSerializedThrift(jaeger_span);
   if (span_size > max_span_bytes)
   {
-    // TODO, log too large span error.
+    OTEL_INTERNAL_LOG_ERROR("[JAEGER TRACE Exporter] Append() failed: too large span");
     return 0;
   }
 

diff --git a/exporters/jaeger/src/udp_transport.cc b/exporters/jaeger/src/udp_transport.cc
@@ -19,9 +19,10 @@ UDPTransport::UDPTransport(const std::string &addr, uint16_t port)
 
   endpoint_transport_ = std::shared_ptr<TTransport>(new TUDPTransport(addr, port));
   endpoint_transport_->open();
-  transport_ = std::shared_ptr<TTransport>(new TBufferedTransport(endpoint_transport_));
-  protocol_  = std::shared_ptr<TProtocol>(new TCompactProtocol(transport_));
-  agent_     = std::unique_ptr<AgentClient>(new AgentClient(protocol_));
+  transport_ =
+      std::shared_ptr<TTransport>(new TBufferedTransport(endpoint_transport_, max_packet_size_));
+  protocol_ = std::shared_ptr<TProtocol>(new TCompactProtocol(transport_));
+  agent_    = std::unique_ptr<AgentClient>(new AgentClient(protocol_));
 }
 
 UDPTransport::~UDPTransport()