Skip to content

Commit

Permalink
conditional include for codecvt header (#1355)
Browse files Browse the repository at this point in the history
  • Loading branch information
@lalitb
lalitb authored Apr 27, 2022
1 parent e233791 commit 3b9bfd4
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion exporters/etw/include/opentelemetry/exporters/etw/utils.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@

#include <algorithm>
#include <chrono>
#include <codecvt>
#include <ctime>
#include <iomanip>
#include <locale>
Expand All @@ -24,6 +23,8 @@
# pragma comment(lib, "Rpcrt4.lib")
# include <Objbase.h>
# pragma comment(lib, "Ole32.Lib")
#else
# include <codecvt>
#endif

OPENTELEMETRY_BEGIN_NAMESPACE
Expand Down

1 comment on commit 3b9bfd4

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'OpenTelemetry-cpp api Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 3b9bfd4 Previous: e233791 Ratio
BM_NestedSpanCreationWithScope 3556.9384826102178 ns/iter 1197.1881277618536 ns/iter 2.97

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.