Skip to content

Commit

Permalink
resolving issues
Browse files Browse the repository at this point in the history
  • Loading branch information
Tianlin-Zhao committed Aug 13, 2020
1 parent 3f73d5d commit 3fa337a
Showing 1 changed file with 22 additions and 21 deletions.
43 changes: 22 additions & 21 deletions api/test/trace/noop_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -9,24 +9,25 @@
using opentelemetry::trace::NoopTracer;
using opentelemetry::trace::Tracer;

TEST(NoopTest, UseNoopTracers)
{
// Note: This test is no longer valid as Span no longer has field of tracer. Whether
// removing it depends on the creator of this file.
// std::shared_ptr<Tracer> tracer{new NoopTracer{}};
// auto s1 = tracer->StartSpan("abc");
// EXPECT_EQ(&s1->tracer(), tracer.get());
//
// std::map<std::string, std::string> attributes1;
// s1->AddEvent("abc", attributes1);
//
// std::vector<std::pair<std::string, int>> attributes2;
// s1->AddEvent("abc", attributes2);
//
// s1->AddEvent("abc", {{"a", 1}, {"b", "2"}, {"c", 3.0}});
//
// std::vector<std::pair<std::string, std::vector<int>>> attributes3;
// s1->AddEvent("abc", attributes3);
//
// s1->SetAttribute("abc", 4);
}
// Note: This test is no longer valid as Span no longer has field of tracer. Whether
// removing it depends on the creator of this file.
// TEST(NoopTest, UseNoopTracers)
//{

// std::shared_ptr<Tracer> tracer{new NoopTracer{}};
// auto s1 = tracer->StartSpan("abc");
// EXPECT_EQ(&s1->tracer(), tracer.get());
//
// std::map<std::string, std::string> attributes1;
// s1->AddEvent("abc", attributes1);
//
// std::vector<std::pair<std::string, int>> attributes2;
// s1->AddEvent("abc", attributes2);
//
// s1->AddEvent("abc", {{"a", 1}, {"b", "2"}, {"c", 3.0}});
//
// std::vector<std::pair<std::string, std::vector<int>>> attributes3;
// s1->AddEvent("abc", attributes3);
//
// s1->SetAttribute("abc", 4);
// }

0 comments on commit 3fa337a

Please sign in to comment.