resolved aditya's questions

open-telemetry · Aug 21, 2020 · 432ab0d · 432ab0d
1 parent 185e8a3
commit 432ab0d
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/api/include/opentelemetry/trace/propagation/http_trace_context.h b/api/include/opentelemetry/trace/propagation/http_trace_context.h
@@ -93,10 +93,9 @@ class HttpTraceContext : public HTTPTextFormat<T>
     }
   }
 
-  static uint8_t[] GenerateBuffer(nostd::string_view string, int bytes)
+  static void GenerateBuffer(nostd::string_view string, int bytes, uint8_t[] buffer)
   {
     const char *str_id = string.begin();
-    uint8_t buf[bytes / 2];
     for (int i = 0; i < bytes; i++)
     {
       int tmp = HexToInt(str_id[i]);
@@ -122,12 +121,16 @@ class HttpTraceContext : public HTTPTextFormat<T>
 
   static TraceId GenerateTraceIdFromString(nostd::string_view trace_id)
   {
-    return TraceId(GenerateBuffer(trace_id, kTraceIdBytes));
+    uint8_t buf[kTraceIdBytes / 2];
+    GenerateBuffer(trace_id, kTraceIdBytes, buf);
+    return TraceId(buf);
   }
 
   static SpanId GenerateSpanIdFromString(nostd::string_view span_id)
   {
-    return SpanId(GenerateBuffer(span_id, kSpanIdBytes));
+    uint8_t buf[kSpanIdBytes / 2];
+    GenerateBuffer(span_id, kSpanIdBytes, buf);
+    return SpanId(buf);
   }
 
   static TraceFlags GenerateTraceFlagsFromString(nostd::string_view trace_flags)