InMemorySpanExporter shutdown fix (#1161)

open-telemetry · Dec 23, 2021 · bb9d5de · bb9d5de
1 parent 1cf2422
commit bb9d5de
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/exporters/memory/include/opentelemetry/exporters/memory/in_memory_span_exporter.h b/exporters/memory/include/opentelemetry/exporters/memory/in_memory_span_exporter.h
@@ -42,6 +42,10 @@ class InMemorySpanExporter final : public opentelemetry::sdk::trace::SpanExporte
   sdk::common::ExportResult Export(
       const nostd::span<std::unique_ptr<sdk::trace::Recordable>> &recordables) noexcept override
   {
+    if (is_shutdown_)
+    {
+      return sdk::common::ExportResult::kFailure;
+    }
     for (auto &recordable : recordables)
     {
       auto span = std::unique_ptr<sdk::trace::SpanData>(
@@ -63,6 +67,7 @@ class InMemorySpanExporter final : public opentelemetry::sdk::trace::SpanExporte
   bool Shutdown(
       std::chrono::microseconds timeout = std::chrono::microseconds::max()) noexcept override
   {
+    is_shutdown_ = true;
     return true;
   };
 
@@ -76,6 +81,7 @@ class InMemorySpanExporter final : public opentelemetry::sdk::trace::SpanExporte
 
 private:
   std::shared_ptr<opentelemetry::exporter::memory::InMemorySpanData> data_;
+  bool is_shutdown_ = false;
 };
 }  // namespace memory
 }  // namespace exporter