Skip to content

Commit

Permalink
[BUILD] Do not set OTELCPP_PROTO_PATH in the CMake cache (#3160)
Browse files Browse the repository at this point in the history
  • Loading branch information
@marcalff
marcalff authored Nov 24, 2024
1 parent fcdd526 commit c1ef416
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions CMakeLists.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -260,10 +260,6 @@ if(OTELCPP_VERSIONED_LIBS AND NOT BUILD_SHARED_LIBS)
message(FATAL_ERROR "OTELCPP_VERSIONED_LIBS=ON requires BUILD_SHARED_LIBS=ON")
endif()

set(OTELCPP_PROTO_PATH
""
CACHE PATH "Path to opentelemetry-proto")

if(WIN32)
option(WITH_ETW "Whether to include the ETW Exporter in the SDK" ON)
else()
Expand Down

1 comment on commit c1ef416

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'OpenTelemetry-cpp api Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: c1ef416 Previous: fcdd526 Ratio
BM_SpinLockThrashing/2/process_time/real_time 0.37986584726323935 ms/iter 0.17675352328031965 ms/iter 2.15
BM_SpinLockThrashing/4/process_time/real_time 1.5854454040527344 ms/iter 0.7024978853992581 ms/iter 2.26

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.