Skip to content

Commit

Permalink
Fix warning for misconfiguration of PeriodicExportingMetricReader (#1929
Browse files Browse the repository at this point in the history
)

The periodically exporting metric reader requires the timeout field to be strictly less than the interval field. However, the warning that is logged out gives the opposite requirement. The existing logic in the code is correct.
  • Loading branch information
jwbuurlage authored Jan 18, 2023
1 parent 59d0bc2 commit c9e76b4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sdk/src/metrics/export/periodic_exporting_metric_reader.cc
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ PeriodicExportingMetricReader::PeriodicExportingMetricReader(
{
OTEL_INTERNAL_LOG_WARN(
"[Periodic Exporting Metric Reader] Invalid configuration: "
"export_interval_millis_ should be less than export_timeout_millis_, using default values");
"export_timeout_millis_ should be less than export_interval_millis_, using default values");
export_interval_millis_ = kExportIntervalMillis;
export_timeout_millis_ = kExportTimeOutMillis;
}
Expand Down

0 comments on commit c9e76b4

Please sign in to comment.