Fix curl thread detach

open-telemetry · Nov 27, 2024 · d5f1075 · d5f1075
1 parent 24816a8
commit d5f1075
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/ext/src/http/client/curl/http_client_curl.cc b/ext/src/http/client/curl/http_client_curl.cc
@@ -462,18 +462,18 @@ void HttpClient::MaybeSpawnBackgroundThread()
             {
               if (self->background_thread_)
               {
+                if (self->background_thread_instrumentation_ != nullptr)
+                {
+                  self->background_thread_instrumentation_->OnEnd();
+                  self->background_thread_instrumentation_.reset();
+                }
                 self->background_thread_->detach();
                 self->background_thread_.reset();
               }
               break;
             }
           }
         }
-
-        if (self->background_thread_instrumentation_ != nullptr)
-        {
-          self->background_thread_instrumentation_->OnEnd();
-        }
       },
       this));
 }