Checking indices before dereference

open-telemetry · Mar 9, 2023 · d9f2def · d9f2def
1 parent 5046443
commit d9f2def
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/api/include/opentelemetry/common/string_util.h b/api/include/opentelemetry/common/string_util.h
@@ -14,11 +14,11 @@ class StringUtil
 public:
   static nostd::string_view Trim(nostd::string_view str, size_t left, size_t right) noexcept
   {
-    while (str[static_cast<std::size_t>(left)] == ' ' && left <= right)
+    while (left <= right && str[static_cast<std::size_t>(left)] == ' ')
     {
       left++;
     }
-    while (str[static_cast<std::size_t>(right)] == ' ' && left <= right)
+    while (left <= right && str[static_cast<std::size_t>(right)] == ' ')
     {
       right--;
     }