Fix a potential precision loss on integer in ReservoirCellIndexFor (#…

…1696)
open-telemetry · Oct 18, 2022 · d9f8bce · d9f8bce · github-actions · Oct 18, 2022
1 parent 7f37bc3
commit d9f8bce
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/sdk/include/opentelemetry/sdk/metrics/exemplar/histogram_exemplar_reservoir.h b/sdk/include/opentelemetry/sdk/metrics/exemplar/histogram_exemplar_reservoir.h
@@ -55,12 +55,12 @@ class HistogramExemplarReservoir : public FixedSizeExemplarReservoir
                               const MetricAttributes & /* attributes */,
                               const opentelemetry::context::Context & /* context */) override
     {
-      int max_size = boundaries_.size();
-      for (int i = 0; i < max_size; ++i)
+      size_t max_size = boundaries_.size();
+      for (size_t i = 0; i < max_size; ++i)
       {
         if (value <= boundaries_[i])
         {
-          return i;
+          return static_cast<int>(i);
         }
       }
       return -1;