Skip to content

Commit

Permalink
cmake: thrift requires boost headers, include them as Boost_INCLUDE_D…
Browse files Browse the repository at this point in the history
…IRS (#1100)
  • Loading branch information
Deepika Upadhyay authored Feb 4, 2022
1 parent a320739 commit e9127fc
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,10 @@ endfunction()

if(WITH_JAEGER)
find_package(Thrift QUIET)
if(NOT Thrift_FOUND)
if(Thrift_FOUND)
find_package(Boost REQUIRED)
include_directories(${Boost_INCLUDE_DIR})
else()
# Install Thrift and propagate via vcpkg toolchain file
if(WIN32 AND (NOT DEFINED CMAKE_TOOLCHAIN_FILE))
install_windows_deps()
Expand Down

1 comment on commit e9127fc

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'OpenTelemetry-cpp sdk Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: e9127fc Previous: a320739 Ratio
BM_BaselineBuffer/1 7408616.64232007 ns/iter 1155283.9279174805 ns/iter 6.41
BM_BaselineBuffer/2 9180319.30923462 ns/iter 3523110.3897094727 ns/iter 2.61

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.