Skip to content

Commit

Permalink
[BUILD] Fix multiple assignment operators for SpinLockMutex (#2501)
Browse files Browse the repository at this point in the history
  • Loading branch information
@SaiHarshaK
SaiHarshaK authored Jan 23, 2024
1 parent a232328 commit fe15d0a
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion api/include/opentelemetry/common/spin_lock_mutex.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ class SpinLockMutex
~SpinLockMutex() noexcept = default;
SpinLockMutex(const SpinLockMutex &) = delete;
SpinLockMutex &operator=(const SpinLockMutex &) = delete;
SpinLockMutex &operator=(const SpinLockMutex &) volatile = delete;

static inline void fast_yield() noexcept
{
Expand Down

2 comments on commit fe15d0a

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'OpenTelemetry-cpp sdk Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: fe15d0a Previous: a232328 Ratio
BM_LockFreeBuffer/2 5004099.571130503 ns/iter 635852.8052360562 ns/iter 7.87
BM_LockFreeBuffer/4 9795269.966125488 ns/iter 1939793.977498694 ns/iter 5.05
BM_SpanCreation 1132.145346171463 ns/iter 561.9923249794813 ns/iter 2.01
BM_NoopSpanCreation 338.5147910026063 ns/iter 142.22629257308367 ns/iter 2.38

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'OpenTelemetry-cpp api Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: fe15d0a Previous: a232328 Ratio
BM_SpinLockThrashing/1/process_time/real_time 9.033543722970146 ms/iter 0.09404837740639041 ms/iter 96.05
BM_SpinLockThrashing/2/process_time/real_time 6.186232509383236 ms/iter 0.20734745210031008 ms/iter 29.84

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.