Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alpine Packages #1950

Closed
svrnm opened this issue Feb 1, 2023 · 5 comments
Closed

Alpine Packages #1950

svrnm opened this issue Feb 1, 2023 · 5 comments

Comments

@svrnm
Copy link
Member

svrnm commented Feb 1, 2023

While playing around with the OpenTelemetry demo applications I figured out that it would be nice to have the ability to load the OpenTelemetry C++ libraries pre-compiled from a package repository like grpc, re2, etc

So instead of

RUN apk add git cmake make g++ grpc-dev re2-dev protobuf-dev c-ares-dev 
RUN git clone opentelemetry-cpp ... build ... make

Wouldn't it be nice to do the following instead?

RUN apk add git cmake make g++ grpc-dev re2-dev protobuf-dev c-ares-dev opentelemetry-cpp-dev

I played around with that a little bit and now I have the following:

https://github.com/svrnm/otel-abuild

I consider to create a merge request with https://gitlab.alpinelinux.org/alpine/aports/, but I wanted to check with you first what you think about that and maybe if there's some feedback on what I created.

Thanks

@marcalff
Copy link
Member

marcalff commented Feb 1, 2023

Thanks @svrnm

From a quick look:

  • add license information on every file ?
  • The jaeger exporter is deprecated, and the build uses WITH_JAEGER=OFF, great. There should be no opentelemetry-cpp-exporter-jaeger package then.
  • For the packages names, maybe use only the opentelemetry-cpp-* namespace, not opentelemetry-* (as seen in RUN apk add ... opentelemetry-dev)

For the license, I assume it will be:

# Copyright The OpenTelemetry Authors
# SPDX-License-Identifier: Apache-2.0

I have not tried the packages yet, will investigate further.

@svrnm
Copy link
Member Author

svrnm commented Feb 1, 2023

add license information on every file ?

The only file that's really relevant is the APKBUILD file, everything else is just there to speed up the build. If this get's added to the official alpine repositories they are no longer needed.

The jaeger exporter is #1892, and the build uses WITH_JAEGER=OFF, great. There should be no opentelemetry-cpp-exporter-jaeger package then.

I forgot to take this off the list of packages that are generated. I just upgraded to 1.8.2 and saw the deprecation notes, will remove it.

For the packages names, maybe use only the opentelemetry-cpp-* namespace, not opentelemetry-* (as seen in RUN apk add ... opentelemetry-dev)

Also a typo, thanks!

@lalitb
Copy link
Member

lalitb commented Feb 1, 2023

This looks good. @svrnm - If you plan to maintain this going ahead, we can list it here along with other unofficially available packages once this get's published.

As a sidenote, opentelemetry-cpp support building binary deb, rpm, NuGet packages using cpack as mentioned here, would be interesting to see what it takes to extend this for building alpine packages.

@svrnm
Copy link
Member Author

svrnm commented Feb 1, 2023

This looks good. @svrnm - If you plan to maintain this going ahead, we can list it here along with other unofficially available packages once this get's published.

I need to dig a little bit what the requirements are from the alpine / aport project, but yes, I am able to maintain it over there.

As a sidenote, opentelemetry-cpp support building binary deb, rpm, NuGet packages using cpack as mentioned here, would be interesting to see what it takes to extend this for building alpine packages.

I was not aware of that, that's super cool! I've no experience with CPACK, so I can not speak about capabilities to create apk/alpine packages, but I can look into it.

@svrnm
Copy link
Member Author

svrnm commented Feb 6, 2023

@lalitb @marcalff it's in "edge/testing" now:

https://pkgs.alpinelinux.org/packages?name=opentelemetry-*&branch=edge&repo=testing&arch=&maintainer=

@svrnm svrnm closed this as completed Feb 6, 2023
svrnm added a commit to svrnm/opentelemetry-cpp that referenced this issue Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants