Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK] TracerProvider should own TracerContext, not share it. #2203

Closed
marcalff opened this issue Jun 27, 2023 · 1 comment · Fixed by #2221
Closed

[SDK] TracerProvider should own TracerContext, not share it. #2203

marcalff opened this issue Jun 27, 2023 · 1 comment · Fixed by #2221
Assignees
@marcalff
Labels
bug Something isn't working

Comments

@marcalff
Copy link
Member

marcalff commented Jun 27, 2023 •
edited
Loading

This is a consequence of SPEC PR:

The TracerProvider object should take and maintain a unique_ptr<TracerContext>, not a shared_ptr<TracerContext>.

Likewise, the LoggerProvider object should take and maintain a unique_ptr<LoggerContext>, not a shared_ptr<LoggerContext>.
@marcalff marcalff added the bug Something isn't working label Jun 27, 2023
@marcalff marcalff self-assigned this Jun 27, 2023
@marcalff marcalff mentioned this issue Jun 27, 2023
Merged
3 tasks
@marcalff
Copy link
Member Author

marcalff commented Jul 6, 2023

Blocked, waiting on spec to be approved and merged.

@marcalff marcalff added issue:blocked Fix blocked, waiting for other fixes as prerequisites and removed issue:blocked Fix blocked, waiting for other fixes as prerequisites labels Jul 6, 2023
marcalff added a commit to marcalff/opentelemetry-cpp that referenced this issue Jul 7, 2023
@marcalff
Fixes open-telemetry#2203
fd581bf
@marcalff marcalff mentioned this issue Jul 7, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcalff marcalff

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[SDK] TracerProvider should own TracerContext, not share it marcalff/opentelemetry-cpp
1 participant
@marcalff