Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otlp grpc log exporter constructor #1063

Merged
merged 2 commits into from
Nov 13, 2021

Conversation

esigo
Copy link
Member

@esigo esigo commented Nov 13, 2021

otlp grpc log exporter constructor should be public

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@esigo esigo requested a review from a team November 13, 2021 17:03
@esigo esigo changed the title otlp grpc exporter constructor otlp grpc log exporter constructor Nov 13, 2021
@codecov
Copy link

codecov bot commented Nov 13, 2021

Codecov Report

Merging #1063 (e1dfc46) into main (eca856d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1063   +/-   ##
=======================================
  Coverage   94.41%   94.41%           
=======================================
  Files         158      158           
  Lines        6077     6077           
=======================================
  Hits         5737     5737           
  Misses        340      340           

@lalitb lalitb merged commit 4a49b1b into open-telemetry:main Nov 13, 2021
@esigo esigo deleted the otlp-grpc-exporter-ctor branch November 13, 2021 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants