Improvement: span_id should not break strict aliasing. #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
lalitb
approved these changes
Nov 16, 2021
Codecov Report
@@ Coverage Diff @@
## main #1068 +/- ##
=======================================
Coverage 94.41% 94.41%
=======================================
Files 158 158
Lines 6077 6077
=======================================
Hits 5737 5737
Misses 340 340
|
ThomsonTan
reviewed
Nov 16, 2021
| @@ -61,7 +61,8 @@ class SpanId final | |||
| bool IsValid() const noexcept | |||
| { | |||
| static_assert(kSize == 8, "update is needed if kSize is not 8"); | |||
There was a problem hiding this comment.
This static_assert could be removed then as the code doesn't make such assumption anymore?
ThomsonTan
approved these changes
Nov 16, 2021
hcoona
force-pushed
the
private/hcoona/fix-strict-aliasing
branch
from
0259f8f
to
0b9daa8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1067