Update maintainers/approvers #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyang
requested review from
g-easy,
jmacd,
maxgolov,
rnburn and
tigrannajaryan
as code owners
reyang
commented
Jun 12, 2020
CONTRIBUTING.md
Outdated
|
|
||
| Select an example of interest from the <a href="https://github.com/open-telemetry/opentelemetry-cpp/tree/master/examples"> examples folder </a>. Inside each example directory is a `BUILD` file containing instructions for Bazel. Find the binary name of your example by inspecting the contents of this `BUILD` file. | ||
| Select an example of interest from the [examples folder](https://github.com/open-telemetry/opentelemetry-cpp/tree/master/examples). Inside each example directory is a `BUILD` file containing instructions for Bazel. Find the binary name of your example by inspecting the contents of this `BUILD` file. |
There was a problem hiding this comment.
It seems we are now very inconsistent with 1 space vs. 2 spaces.
Wish to get more perspectives before I try to make them consistent.
I personally vote for just having 1 space since it is easier to maintain.
There was a problem hiding this comment.
1 space looks good. Some Markdown editors (e.g. MS Word, for example) tend to insert double-space or even a space that's not 0x20 :)
There was a problem hiding this comment.
Sweet, changed all the 2 spaces to 1 space.
maxgolov
approved these changes
Jun 12, 2020
g-easy
approved these changes
Jun 12, 2020
pyohannes
approved these changes
Jun 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C/C++toC++based on our decision that we're not going to provide C interface in this repo.I will update the community repo after this PR.