Improve the instructions for Bazel build. #1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasireddy99
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1136 +/- ##
==========================================
+ Coverage 93.37% 93.39% +0.02%
==========================================
Files 165 165
Lines 6229 6229
==========================================
+ Hits 5816 5817 +1
+ Misses 413 412 -1
|
lalitb
reviewed
Dec 14, 2021
ThomsonTan
approved these changes
Dec 15, 2021
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to propose the changes in instructions for building with bazel and adding the note to not to have GoogleTest installed.
Bazel will download, build and install gtest version from here and it will fail if it gets different gtest headers from system defined path.
Please feel free to add review comments.